Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/17872 )
Change subject: IMPALA-10811 RPC to submit query getting stuck for AWS NLB forever ...................................................................... Patch Set 33: (2 comments) Thanks for incorporating the test, just some last notes http://gerrit.cloudera.org:8080/#/c/17872/33/be/src/service/client-request-state.cc File be/src/service/client-request-state.cc: http://gerrit.cloudera.org:8080/#/c/17872/33/be/src/service/client-request-state.cc@703 PS33, Line 703: if (exec_dml_sync) { What I meant to say is that "exec_dml_sync" is a name that is the opposite of its boolean value. "exec_dml_sync" is currently true when we are running asynchronously in the worker thread and false when we are running synchronously in the main thread. I just want the name to align with the condition. i.e. either "if (!exec_ddl_sync)" or "if (exec_ddl_async)". I have a bit of brain fuzz, and I also missed that this should be "ddl" rather than "dml" (here and elsewhere). http://gerrit.cloudera.org:8080/#/c/17872/33/be/src/service/client-request-state.cc@710 PS33, Line 710: : // Optionally wait with a debug action before Exec() below. : DebugActionNoFail( : exec_request_->query_options, "CRS_DELAY_BEFORE_CATALOG_OP_EXEC"); I'm sorry, I should have mentioned that my extra test will need this to be outside the if statement, because it is testing delays for both the sync and async cases. -- To view, visit http://gerrit.cloudera.org:8080/17872 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib57e86926a233ef13d27a9ec8d9c36d33a88a44e Gerrit-Change-Number: 17872 Gerrit-PatchSet: 33 Gerrit-Owner: Qifan Chen <qc...@cloudera.com> Gerrit-Reviewer: Amogh Margoor <amarg...@gmail.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Qifan Chen <qc...@cloudera.com> Gerrit-Comment-Date: Thu, 21 Oct 2021 17:06:14 +0000 Gerrit-HasComments: Yes
