Qifan Chen has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/17872 )

Change subject: IMPALA-10811 RPC to submit query getting stuck for AWS NLB 
forever
......................................................................


Patch Set 34:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/17872/33/be/src/service/client-request-state.cc
File be/src/service/client-request-state.cc:

http://gerrit.cloudera.org:8080/#/c/17872/33/be/src/service/client-request-state.cc@703
PS33, Line 703:   if (exec_in_worker_t
> What I meant to say is that "exec_dml_sync" is a name that is the opposite
Renamed to exec_in_worker_thread. I was having hard time interpreting the 
previously named argument too. This name should help a lot.

Done


http://gerrit.cloudera.org:8080/#/c/17872/33/be/src/service/client-request-state.cc@710
PS33, Line 710:   }
              : 
              :   // Optionally wait with a debug action before Exec() below.
              :   DebugActionNoFail(exec_request_->query_options, 
"CRS_DELAY_BEFORE_CATALO
> I'm sorry, I should have mentioned that my extra test will need this to be
The change will make the execution time (exec_time) longer than 10s, for the 
sync mode in general. Modified your test cases accordingly.

Done.



--
To view, visit http://gerrit.cloudera.org:8080/17872
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib57e86926a233ef13d27a9ec8d9c36d33a88a44e
Gerrit-Change-Number: 17872
Gerrit-PatchSet: 34
Gerrit-Owner: Qifan Chen <qc...@cloudera.com>
Gerrit-Reviewer: Amogh Margoor <amarg...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com>
Gerrit-Reviewer: Qifan Chen <qc...@cloudera.com>
Gerrit-Comment-Date: Thu, 21 Oct 2021 17:52:43 +0000
Gerrit-HasComments: Yes

Reply via email to