Qifan Chen has posted comments on this change. ( http://gerrit.cloudera.org:8080/17955 )
Change subject: IMPALA-10967 Load data should handle AWS NLB-type timeout ...................................................................... Patch Set 7: (3 comments) Thanks a lot Joe for the review comments! http://gerrit.cloudera.org:8080/#/c/17955/6/be/src/service/client-request-state.cc File be/src/service/client-request-state.cc: http://gerrit.cloudera.org:8080/#/c/17955/6/be/src/service/client-request-state.cc@769 PS6, Line 769: if (exec_in_worker_thread) { : DCHECK(exec_state() == ExecState::PENDING); > Nit: My only thought here is that I do like it when these statements are ri Done http://gerrit.cloudera.org:8080/#/c/17955/6/tests/metadata/test_load.py File tests/metadata/test_load.py: http://gerrit.cloudera.org:8080/#/c/17955/6/tests/metadata/test_load.py@111 PS6, Line 111: @SkipIfLocal.hdfs_client > One thing about subclassing TestLoadData is that TestAsyncLoadData will get Made this class a direct subclass of ImpalaTestSuite as it helps reduce some unnecessary dependency too. Done. http://gerrit.cloudera.org:8080/#/c/17955/6/tests/metadata/test_load.py@122 PS6, Line 122: create_uncompressed_text_dimension(cls.get_workload())) > Nice to have: When possible, we want to structure tests to allow them to ex Yeah, the test time is longer with serial mode. Good to know the limitation with unique_database + setup/teardown. Formed protocol and async_ddl_exec dependent staging path name which worked pretty well. It has to be within each test_async_load() to eliminate the sharing of staging path completely. The test time is about 1min now. -- To view, visit http://gerrit.cloudera.org:8080/17955 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8c2437e9894510204303ec07710cad60102c8821 Gerrit-Change-Number: 17955 Gerrit-PatchSet: 7 Gerrit-Owner: Qifan Chen <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Qifan Chen <[email protected]> Gerrit-Comment-Date: Tue, 26 Oct 2021 18:15:21 +0000 Gerrit-HasComments: Yes
