Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/17955 )
Change subject: IMPALA-10967 Load data should handle AWS NLB-type timeout ...................................................................... Patch Set 9: Code-Review+2 (1 comment) Thanks for the changes, this is looking good to me. http://gerrit.cloudera.org:8080/#/c/17955/9/tests/metadata/test_load.py File tests/metadata/test_load.py: http://gerrit.cloudera.org:8080/#/c/17955/9/tests/metadata/test_load.py@139 PS9, Line 139: # Form a fully qualified table name with '-' in protocol 'hs2-http' dropped as : # '-' is not allowed in Impala table name even delimited with ``. : qualified_table_name = '{0}.{1}_{2}_{3}'.format(unique_database, TEST_TBL_NOPART, : protocol if protocol != 'hs2-http' else 'hs2http', enable_async_load_data) : : # Form a staging path that is protocol and enable_async_load_data dependent to : # allow parallel creating distinct HDFS directories for each test object. : staging_path = "{0}_{1}_{2}".format(STAGING_PATH, protocol, enable_async_load_data) Just so you know: the unique_database name has one part that is based on the test name and another part that is a unique identifier based on the complete pytest description (which includes parameters from test dimensions). https://github.com/apache/impala/blob/master/tests/conftest.py#L265 The second part makes it generally safe to assume that multiple runs of the same test with different parameters will have different unique databases. Tests often rely on that and keep the table names simple. Tests can also use the actual unique database directory as a unique place. Here's an example of some code that is using the database directory name: https://github.com/apache/impala/blob/master/tests/common/file_utils.py#L49-L50 This is purely informational, in case it is useful later. -- To view, visit http://gerrit.cloudera.org:8080/17955 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8c2437e9894510204303ec07710cad60102c8821 Gerrit-Change-Number: 17955 Gerrit-PatchSet: 9 Gerrit-Owner: Qifan Chen <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Qifan Chen <[email protected]> Gerrit-Comment-Date: Tue, 26 Oct 2021 18:56:50 +0000 Gerrit-HasComments: Yes
