Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/17948 )
Change subject: WIP IMPALA-10931: Integrate protobuf 3.14.0 library with Impala ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/17948/2/be/src/rpc/rpc-mgr.cc File be/src/rpc/rpc-mgr.cc: http://gerrit.cloudera.org:8080/#/c/17948/2/be/src/rpc/rpc-mgr.cc@100 PS2, Line 100: // Since Kudu client shared library has its own protobuf, there are two copies of protobuf : // library in Impala's binary. Each copy has independent descriptor pool, but they : // interact each other at static-initialization time, which cause AddDescriptors() is not : // called for .proto files for Impala's protobuf. : // This function load descriptors for google/protobuf/descriptor.proto, which are used by : // rpc_header.proto. > Just trying to wrap my head around the root cause here. Am I correct in und Your understanding is correct. http://gerrit.cloudera.org:8080/#/c/17948/2/be/src/rpc/rpc-mgr.cc@108 PS2, Line 108: static bool CheckProtobufDescriptorProto() { > Given the issue we're fixing is quite nuanced, perhaps it's worth adding li Added the link in the comments. -- To view, visit http://gerrit.cloudera.org:8080/17948 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia1df4faceff9fda169c9d15fe8b1e69cfabe0d43 Gerrit-Change-Number: 17948 Gerrit-PatchSet: 2 Gerrit-Owner: Wenzhe Zhou <wz...@cloudera.com> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com> Gerrit-Comment-Date: Fri, 29 Oct 2021 00:54:19 +0000 Gerrit-HasComments: Yes
