Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/17948 )
Change subject: WIP IMPALA-10951 (part 2): Upgrade protobuf library to 3.14.0 for Impala ...................................................................... Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/17948/5/be/src/kudu/rpc/result_tracker.h File be/src/kudu/rpc/result_tracker.h: http://gerrit.cloudera.org:8080/#/c/17948/5/be/src/kudu/rpc/result_tracker.h@286 PS5, Line 286: 0) > The length of previous line is already 90, have to break it as two lines to Ok, I see. For some reason Gerrit is not showing the 90 character limit line for me. Since this is Kudu code transplanted into Impala, I would also be ok with leaving it however Kudu has it (and ignoring warnings about it). -- To view, visit http://gerrit.cloudera.org:8080/17948 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia1df4faceff9fda169c9d15fe8b1e69cfabe0d43 Gerrit-Change-Number: 17948 Gerrit-PatchSet: 5 Gerrit-Owner: Wenzhe Zhou <wz...@cloudera.com> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com> Gerrit-Comment-Date: Thu, 11 Nov 2021 17:52:07 +0000 Gerrit-HasComments: Yes
