Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/17983 )
Change subject: IMPALA-10920: Zipping unnest for arrays ...................................................................... Patch Set 4: (4 comments) PS3 is fixing a bug with predicates being incorrectly pushed down to SCAN node. PS4 is fixing the comments from Jenkins plus eventually writing the commit msg. Will start processing the comments from Csaba and Daniel now. Thanks for taking a look! http://gerrit.cloudera.org:8080/#/c/17983/3/fe/src/main/java/org/apache/impala/analysis/UnnestExpr.java File fe/src/main/java/org/apache/impala/analysis/UnnestExpr.java: http://gerrit.cloudera.org:8080/#/c/17983/3/fe/src/main/java/org/apache/impala/analysis/UnnestExpr.java@49 PS3, Line 49: protected void analyzeImpl(Analyzer analyzer) throws AnalysisException { > line has trailing whitespace Done http://gerrit.cloudera.org:8080/#/c/17983/3/fe/src/main/java/org/apache/impala/analysis/UnnestExpr.java@50 PS3, Line 50: Preconditions.checkNotNull(rawPath_); > line has trailing whitespace Done http://gerrit.cloudera.org:8080/#/c/17983/3/fe/src/main/java/org/apache/impala/analysis/UnnestExpr.java@109 PS3, Line 109: Type resolvedType = > line has trailing whitespace Done http://gerrit.cloudera.org:8080/#/c/17983/3/tests/query_test/test_nested_types.py File tests/query_test/test_nested_types.py: http://gerrit.cloudera.org:8080/#/c/17983/3/tests/query_test/test_nested_types.py@196 PS3, Line 196: > flake8: E302 expected 2 blank lines, found 1 Done -- To view, visit http://gerrit.cloudera.org:8080/17983 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic58ff6579ecff03962e7a8698edfbe0684ce6cf7 Gerrit-Change-Number: 17983 Gerrit-PatchSet: 4 Gerrit-Owner: Gabor Kaszab <gaborkas...@cloudera.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Daniel Becker <daniel.bec...@cloudera.com> Gerrit-Reviewer: Gabor Kaszab <gaborkas...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Comment-Date: Tue, 09 Nov 2021 09:34:36 +0000 Gerrit-HasComments: Yes
