Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/17983 )
Change subject: IMPALA-10920: Zipping unnest for arrays ...................................................................... Patch Set 6: (4 comments) http://gerrit.cloudera.org:8080/#/c/17983/5/be/src/exec/unnest-node.h File be/src/exec/unnest-node.h: http://gerrit.cloudera.org:8080/#/c/17983/5/be/src/exec/unnest-node.h@46 PS5, Line 46: d > Nit: typo 'handled'. Done http://gerrit.cloudera.org:8080/#/c/17983/5/fe/src/main/java/org/apache/impala/analysis/StmtRewriter.java File fe/src/main/java/org/apache/impala/analysis/StmtRewriter.java: http://gerrit.cloudera.org:8080/#/c/17983/5/fe/src/main/java/org/apache/impala/analysis/StmtRewriter.java@1870 PS5, Line 1870: Preconditions.checkState(stmt.getResultExprs().size() >= unnestTableRefs.size()); > Is this line necessary? If the size is 0 the precondition below cannot fail Done http://gerrit.cloudera.org:8080/#/c/17983/2/fe/src/main/java/org/apache/impala/analysis/UnnestExpr.java File fe/src/main/java/org/apache/impala/analysis/UnnestExpr.java: http://gerrit.cloudera.org:8080/#/c/17983/2/fe/src/main/java/org/apache/impala/analysis/UnnestExpr.java@42 PS2, Line 42: > If the support for arr.item is removed, we should modify this comment to re Done http://gerrit.cloudera.org:8080/#/c/17983/5/fe/src/main/java/org/apache/impala/analysis/UnnestExpr.java File fe/src/main/java/org/apache/impala/analysis/UnnestExpr.java: http://gerrit.cloudera.org:8080/#/c/17983/5/fe/src/main/java/org/apache/impala/analysis/UnnestExpr.java@31 PS5, Line 31: > Nit: typo 'a'. Done -- To view, visit http://gerrit.cloudera.org:8080/17983 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic58ff6579ecff03962e7a8698edfbe0684ce6cf7 Gerrit-Change-Number: 17983 Gerrit-PatchSet: 6 Gerrit-Owner: Gabor Kaszab <gaborkas...@cloudera.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Daniel Becker <daniel.bec...@cloudera.com> Gerrit-Reviewer: Gabor Kaszab <gaborkas...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Comment-Date: Wed, 10 Nov 2021 16:21:20 +0000 Gerrit-HasComments: Yes
