Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/17999 )
Change subject: IMPALA-11006: Impalad crashes during query cancel tests ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/17999/1/be/src/service/client-request-state.cc File be/src/service/client-request-state.cc: http://gerrit.cloudera.org:8080/#/c/17999/1/be/src/service/client-request-state.cc@1070 PS1, Line 1070: else > CTAS is processed async with a difference before the RPC patch. My concern is about queries that do not have a coordinator at all, as FinishExecQueryOrDmlRequest is not called. My understanding is that there is no coordinator in case of DDLs, with the exception of CTAS. In this case it is normal to go in this branch - we will work correctly, but I still think that we should distinguish between the two cases. http://gerrit.cloudera.org:8080/#/c/17999/1/be/src/service/client-request-state.cc@1076 PS1, Line 1076: MarkInactive > I instrumented the code to observe when MarkActive() and MarkInactive() for MarkActive/Inactive affects query expiration only, which is not relevant in case the query was cancelled. ref_count_ should reach 0 only when Impala is really not doing any work on the query and we are waiting for the client to do another RPC. -- To view, visit http://gerrit.cloudera.org:8080/17999 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia49411f8525734b8d463d9ffbfbce705b90a8d73 Gerrit-Change-Number: 17999 Gerrit-PatchSet: 2 Gerrit-Owner: Qifan Chen <qc...@cloudera.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Qifan Chen <qc...@cloudera.com> Gerrit-Comment-Date: Tue, 09 Nov 2021 16:08:12 +0000 Gerrit-HasComments: Yes
