Qifan Chen has posted comments on this change. ( http://gerrit.cloudera.org:8080/17999 )
Change subject: IMPALA-11006: Impalad crashes during query cancel tests ...................................................................... Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/17999/1/be/src/service/client-request-state.cc File be/src/service/client-request-state.cc: http://gerrit.cloudera.org:8080/#/c/17999/1/be/src/service/client-request-state.cc@1070 PS1, Line 1070: re > My concern is about queries that do not have a coordinator at all, as Finis CTAS is the only DDL that we call ExecQueryOrDmlRequest() and thus FinishExecQueryOrDmlRequest(). See https://github.com/apache/impala/blob/master/be/src/service/client-request-state.cc#L721. All other DDLs, if run async, will execute the rest of the code in ExecDdlRequestImpl(), or ExecDdlRequestImplSync() if run sync. Added a IF test for CTAS that requires a coordinator. If true, we further test is_cancelled_. http://gerrit.cloudera.org:8080/#/c/17999/1/be/src/service/client-request-state.cc@1076 PS1, Line 1076: be no query > MarkActive/Inactive affects query expiration only, which is not relevant in MarkInactive() call is removed. -- To view, visit http://gerrit.cloudera.org:8080/17999 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia49411f8525734b8d463d9ffbfbce705b90a8d73 Gerrit-Change-Number: 17999 Gerrit-PatchSet: 3 Gerrit-Owner: Qifan Chen <qc...@cloudera.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Qifan Chen <qc...@cloudera.com> Gerrit-Comment-Date: Wed, 10 Nov 2021 03:32:44 +0000 Gerrit-HasComments: Yes
