Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/17983 )
Change subject: IMPALA-10920: Zipping unnest for arrays ...................................................................... Patch Set 8: (2 comments) http://gerrit.cloudera.org:8080/#/c/17983/8/fe/src/test/java/org/apache/impala/authorization/AuthorizationStmtTest.java File fe/src/test/java/org/apache/impala/authorization/AuthorizationStmtTest.java: http://gerrit.cloudera.org:8080/#/c/17983/8/fe/src/test/java/org/apache/impala/authorization/AuthorizationStmtTest.java@753 PS8, Line 753: id", "int_struct_col This doesn't look good, as none of the the columns is int_array_col, so the query shouldn't be allowed. http://gerrit.cloudera.org:8080/#/c/17983/8/testdata/workloads/functional-query/queries/QueryTest/zipping-unnest-in-select-list.test File testdata/workloads/functional-query/queries/QueryTest/zipping-unnest-in-select-list.test: http://gerrit.cloudera.org:8080/#/c/17983/8/testdata/workloads/functional-query/queries/QueryTest/zipping-unnest-in-select-list.test@174 PS8, Line 174: ---- QUERY Is it valid to add multiple ---- QUERY sections in a test case? Is it possible that only one will be executed? -- To view, visit http://gerrit.cloudera.org:8080/17983 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic58ff6579ecff03962e7a8698edfbe0684ce6cf7 Gerrit-Change-Number: 17983 Gerrit-PatchSet: 8 Gerrit-Owner: Gabor Kaszab <gaborkas...@cloudera.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Daniel Becker <daniel.bec...@cloudera.com> Gerrit-Reviewer: Gabor Kaszab <gaborkas...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Comment-Date: Fri, 19 Nov 2021 09:14:04 +0000 Gerrit-HasComments: Yes
