wangsheng has posted comments on this change. ( http://gerrit.cloudera.org:8080/18040 )
Change subject: IMPALA-11021: Fix bug when query contains illegal predicate hints ...................................................................... Patch Set 2: (3 comments) Hi Zoltan and Quanlong, thanks for your cr, I've already added a new check to replace the original check. How do you think? http://gerrit.cloudera.org:8080/#/c/18040/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/18040/1//COMMIT_MSG@10 PS1, Line 10: keyword. > nit: keyword Done http://gerrit.cloudera.org:8080/#/c/18040/1//COMMIT_MSG@17 PS1, Line 17: New predicate : analyze will add hint warning to 'GlobalState.warnings' > Shouldn't we avoid adding warnings for new/substituted predicates which are Done http://gerrit.cloudera.org:8080/#/c/18040/1//COMMIT_MSG@21 PS1, Line 21: This check is added in IMPALA-4166, I removed original condition check : and added a new check to ensure that all warnings for new/substituted : predicates are already exists in 'globalState_.warnings'. And this will : also avoiding exception caused by illegal hints. : > I think it would be nice to preserve something from the original intent, i. Done -- To view, visit http://gerrit.cloudera.org:8080/18040 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id719bc4280c811456333eb4b4ec5bc9cb8bae128 Gerrit-Change-Number: 18040 Gerrit-PatchSet: 2 Gerrit-Owner: wangsheng <sky...@163.com> Gerrit-Reviewer: Amogh Margoor <amarg...@gmail.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: Zoltan Borok-Nagy <borokna...@cloudera.com> Gerrit-Reviewer: wangsheng <sky...@163.com> Gerrit-Comment-Date: Tue, 23 Nov 2021 15:53:05 +0000 Gerrit-HasComments: Yes
