Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/18040 )
Change subject: IMPALA-11021: Fix bug when query contains illegal predicate hints ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/18040/2/fe/src/main/java/org/apache/impala/analysis/Analyzer.java File fe/src/main/java/org/apache/impala/analysis/Analyzer.java: http://gerrit.cloudera.org:8080/#/c/18040/2/fe/src/main/java/org/apache/impala/analysis/Analyzer.java@3289 PS2, Line 3289: public void addWarning(String msg) { Sorry that I didn't explain my meaning clearly. I haven't looked into all the callers of this. But can we avoid calling 'addWarning' for the illegal cases? I think this is what the precondition check expects. BTW, I'm ok to the current solution if the above idea is too complex to implement. -- To view, visit http://gerrit.cloudera.org:8080/18040 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id719bc4280c811456333eb4b4ec5bc9cb8bae128 Gerrit-Change-Number: 18040 Gerrit-PatchSet: 2 Gerrit-Owner: wangsheng <sky...@163.com> Gerrit-Reviewer: Amogh Margoor <amarg...@gmail.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: Zoltan Borok-Nagy <borokna...@cloudera.com> Gerrit-Reviewer: wangsheng <sky...@163.com> Gerrit-Comment-Date: Wed, 24 Nov 2021 01:54:29 +0000 Gerrit-HasComments: Yes
