wangsheng has uploaded a new patch set (#7). ( http://gerrit.cloudera.org:8080/18099 )
Change subject: IMPALA-11049: Added expr analyzed check in 'SimplifyCastExprRule.java' ...................................................................... IMPALA-11049: Added expr analyzed check in 'SimplifyCastExprRule.java' We added a new expr rewrite rule 'SimplifyCastExprRule.java' in IMPALA-10836. If expr is not analyzed, this rewrite rule would throw an 'AnalysisException', this is due to 'orderByElements_' not been analyzed. We try to substitute order by elements when creating 'SortInfo', but caused some other problems. So we only add expr analyzed check in this rule to solve this problem. When adding other expr rewrite rules in the future, we should also add this check. Testing: - Added test cases in 'explain-level3.test' Change-Id: I2780e04a6d5a32e224cd0470cf6f166a832363ec --- M fe/src/main/java/org/apache/impala/rewrite/SimplifyCastExprRule.java M testdata/workloads/functional-query/queries/QueryTest/explain-level3.test 2 files changed, 62 insertions(+), 0 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/99/18099/7 -- To view, visit http://gerrit.cloudera.org:8080/18099 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I2780e04a6d5a32e224cd0470cf6f166a832363ec Gerrit-Change-Number: 18099 Gerrit-PatchSet: 7 Gerrit-Owner: wangsheng <sky...@163.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: Zoltan Borok-Nagy <borokna...@cloudera.com> Gerrit-Reviewer: wangsheng <sky...@163.com>
