wangsheng has posted comments on this change. ( http://gerrit.cloudera.org:8080/18099 )
Change subject: IMPALA-11049: Substitute order by elements when creating SortInfo ...................................................................... Patch Set 5: (1 comment) Hi Quanlong, thanks for review this patch. I also submit a pre-review-test, almost 25 test cases failed. I will check these failed tests one by one. http://gerrit.cloudera.org:8080/#/c/18099/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/18099/1//COMMIT_MSG@15 PS1, Line 15: ts_' in-place, and : use these substituted exprs to create 'SortInfo'. B > I mean the EXPLAIN output already prints out the rewritten SQL, even withou Thanks for explain, how about this new example? Compare 'sortInfo_' before and after this patch. -- To view, visit http://gerrit.cloudera.org:8080/18099 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2780e04a6d5a32e224cd0470cf6f166a832363ec Gerrit-Change-Number: 18099 Gerrit-PatchSet: 5 Gerrit-Owner: wangsheng <sky...@163.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: Zoltan Borok-Nagy <borokna...@cloudera.com> Gerrit-Reviewer: wangsheng <sky...@163.com> Gerrit-Comment-Date: Sun, 23 Jan 2022 12:33:25 +0000 Gerrit-HasComments: Yes
