Gergely Fürnstáhl has posted comments on this change. ( http://gerrit.cloudera.org:8080/18289 )
Change subject: IMPALA-11153: Expose LOCK_RETRIES/LOCK_RETRY_WAIT_SECONDS settings for user ...................................................................... Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/18289/2/fe/src/main/java/org/apache/impala/catalog/Hive3MetastoreShimBase.java File fe/src/main/java/org/apache/impala/catalog/Hive3MetastoreShimBase.java: http://gerrit.cloudera.org:8080/#/c/18289/2/fe/src/main/java/org/apache/impala/catalog/Hive3MetastoreShimBase.java@620 PS2, Line 620: * @param lockWaitSeconds Time interval between retries of acquiring an HMS ACID lock. nit: alignment is off here, but as I see we don't have a consistent style for it http://gerrit.cloudera.org:8080/#/c/18289/2/fe/src/main/java/org/apache/impala/service/Frontend.java File fe/src/main/java/org/apache/impala/service/Frontend.java: http://gerrit.cloudera.org:8080/#/c/18289/2/fe/src/main/java/org/apache/impala/service/Frontend.java@2195 PS2, Line 2195: missing comment of queryOptions param http://gerrit.cloudera.org:8080/#/c/18289/2/tests/query_test/test_acid.py File tests/query_test/test_acid.py: http://gerrit.cloudera.org:8080/#/c/18289/2/tests/query_test/test_acid.py@334 PS2, Line 334: assert elapsed < 5 this should be < 3 I think, as >3 && < 5 would mean we had 1 retry -- To view, visit http://gerrit.cloudera.org:8080/18289 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I055b76138dd30b2c40eedb48905cb3bade1438fc Gerrit-Change-Number: 18289 Gerrit-PatchSet: 2 Gerrit-Owner: Zoltan Borok-Nagy <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Gergely Fürnstáhl <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Comment-Date: Fri, 04 Mar 2022 14:38:31 +0000 Gerrit-HasComments: Yes
