Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/18289 )
Change subject: IMPALA-11153: Expose LOCK_RETRIES/LOCK_RETRY_WAIT_SECONDS settings for user ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/18289/2/common/thrift/CatalogService.thrift File common/thrift/CatalogService.thrift: http://gerrit.cloudera.org:8080/#/c/18289/2/common/thrift/CatalogService.thrift@171 PS2, Line 171: lock_retry_wait_seconds Aren't we pessimistic about "seconds"? I don't know how much overhead do we add with the RPCs to Hive, but I think that smaller retry times like 200 ms could be reasonable. We could use lock_retry_wait_ms instead. http://gerrit.cloudera.org:8080/#/c/18289/2/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java File fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java: http://gerrit.cloudera.org:8080/#/c/18289/2/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java@483 PS2, Line 483: ddlRequest.getLock_max_retries(), ddlRequest.getLock_retry_wait_seconds() Just an idea to make passing these parameters simpler: the params in ddlRequest that come from query options could be collected to a struct and that could be passed here. e.g. it could contain debug_action too, which may become useful in the future in RPCs -- To view, visit http://gerrit.cloudera.org:8080/18289 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I055b76138dd30b2c40eedb48905cb3bade1438fc Gerrit-Change-Number: 18289 Gerrit-PatchSet: 2 Gerrit-Owner: Zoltan Borok-Nagy <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Gergely Fürnstáhl <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Comment-Date: Fri, 04 Mar 2022 17:42:03 +0000 Gerrit-HasComments: Yes
