Qifan Chen has posted comments on this change. ( http://gerrit.cloudera.org:8080/18178 )
Change subject: IMPALA-10992 Planner changes for estimate peak memory ...................................................................... Patch Set 17: (5 comments) Thanks! http://gerrit.cloudera.org:8080/#/c/18178/16/common/thrift/Frontend.thrift File common/thrift/Frontend.thrift: http://gerrit.cloudera.org:8080/#/c/18178/16/common/thrift/Frontend.thrift@734 PS16, Line 734: max_mem_l > nit: wondering if it makes sense to just call it max_mem_limit. Done http://gerrit.cloudera.org:8080/#/c/18178/13/fe/src/main/java/org/apache/impala/service/Frontend.java File fe/src/main/java/org/apache/impala/service/Frontend.java: http://gerrit.cloudera.org:8080/#/c/18178/13/fe/src/main/java/org/apache/impala/service/Frontend.java@1937 PS13, Line 1937: eak; > Can this be converted into a Preconditions.check then? Done http://gerrit.cloudera.org:8080/#/c/18178/16/fe/src/main/java/org/apache/impala/service/Frontend.java File fe/src/main/java/org/apache/impala/service/Frontend.java: http://gerrit.cloudera.org:8080/#/c/18178/16/fe/src/main/java/org/apache/impala/service/Frontend.java@1756 PS16, Line 1756: max_mem_limit field. A group set is considered useless if its : * name is not a suff > nit: mentioned the default executor group case as an exception Done http://gerrit.cloudera.org:8080/#/c/18178/16/fe/src/main/java/org/apache/impala/service/Frontend.java@1784 PS16, Line 1784: mit(64*MEGA > nit: wondering if this is low enough to always be rejected The value of 64MB was chosen to allow some queries to use the small group, and other the large group. http://gerrit.cloudera.org:8080/#/c/18178/16/fe/src/main/java/org/apache/impala/service/Frontend.java@1787 PS16, Line 1787: > nit: would be good to also retain the name if one exists. Otherwise this wo Done -- To view, visit http://gerrit.cloudera.org:8080/18178 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I75cf17290be2c64fd4b732a5505bdac31869712a Gerrit-Change-Number: 18178 Gerrit-PatchSet: 17 Gerrit-Owner: Qifan Chen <qc...@cloudera.com> Gerrit-Reviewer: Bikramjeet Vig <bikramjeet....@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Kurt Deschler <kdesc...@cloudera.com> Gerrit-Reviewer: Qifan Chen <qc...@cloudera.com> Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com> Gerrit-Comment-Date: Fri, 04 Mar 2022 22:23:23 +0000 Gerrit-HasComments: Yes
