Kurt Deschler has posted comments on this change. ( http://gerrit.cloudera.org:8080/18178 )
Change subject: IMPALA-10992 Planner changes for estimate peak memory ...................................................................... Patch Set 18: (11 comments) http://gerrit.cloudera.org:8080/#/c/18178/18//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/18178/18//COMMIT_MSG@51 PS18, Line 51: increase can be avoided if they can be compiled in sinlge iteration Typo sinlge http://gerrit.cloudera.org:8080/#/c/18178/18//COMMIT_MSG@66 PS18, Line 66: q15 314MB 13.12 4.51 190.91% These numbers that are over 100% are a little concerning. What is the reason? http://gerrit.cloudera.org:8080/#/c/18178/18/common/thrift/Query.thrift File common/thrift/Query.thrift: http://gerrit.cloudera.org:8080/#/c/18178/18/common/thrift/Query.thrift@584 PS18, Line 584: 144: optional bool enable_replan = true; Why are these declared optional with defaults? http://gerrit.cloudera.org:8080/#/c/18178/18/fe/src/main/java/org/apache/impala/analysis/Analyzer.java File fe/src/main/java/org/apache/impala/analysis/Analyzer.java: http://gerrit.cloudera.org:8080/#/c/18178/18/fe/src/main/java/org/apache/impala/analysis/Analyzer.java@509 PS18, Line 509: private int numExecutors_ = -1; Rename to numExecutorsForPlanning or simething of the like si it is clear by the name that this is a transient value. http://gerrit.cloudera.org:8080/#/c/18178/18/fe/src/main/java/org/apache/impala/analysis/Analyzer.java@563 PS18, Line 563: public int numExecutors() { Same as above, helpful if name clarifies transient behavior. Maybe currentNumExecutors? http://gerrit.cloudera.org:8080/#/c/18178/18/fe/src/main/java/org/apache/impala/planner/ResourceProfileBuilder.java File fe/src/main/java/org/apache/impala/planner/ResourceProfileBuilder.java: http://gerrit.cloudera.org:8080/#/c/18178/18/fe/src/main/java/org/apache/impala/planner/ResourceProfileBuilder.java@44 PS18, Line 44: public ResourceProfileBuilder() {} Is this (empty) ctor required somewhere? http://gerrit.cloudera.org:8080/#/c/18178/18/fe/src/main/java/org/apache/impala/service/Frontend.java File fe/src/main/java/org/apache/impala/service/Frontend.java: http://gerrit.cloudera.org:8080/#/c/18178/18/fe/src/main/java/org/apache/impala/service/Frontend.java@1771 PS18, Line 1771: // The original group has 0 executors. Return one with the number of default Not clear what is meant by "original group" here. http://gerrit.cloudera.org:8080/#/c/18178/18/fe/src/main/java/org/apache/impala/service/Frontend.java@1832 PS18, Line 1832: return Long.compare(e1.getMax_mem_limit(), e2.getMax_mem_limit()); Should sort by additional field(s) so result is deterministic if memory is equal. http://gerrit.cloudera.org:8080/#/c/18178/18/fe/src/main/java/org/apache/impala/service/Frontend.java@1929 PS18, Line 1929: if (queryOptions.num_nodes == 1) { Use planCtx.isSingleNodeExec() instead http://gerrit.cloudera.org:8080/#/c/18178/18/fe/src/main/java/org/apache/impala/service/Frontend.java@1962 PS18, Line 1962: if (reason == null && group_set.getMax_mem_limit() > 0) { Maybe safer to not check reason here and make the default "Unknown" above. http://gerrit.cloudera.org:8080/#/c/18178/18/fe/src/test/java/org/apache/impala/common/QueryFixture.java File fe/src/test/java/org/apache/impala/common/QueryFixture.java: http://gerrit.cloudera.org:8080/#/c/18178/18/fe/src/test/java/org/apache/impala/common/QueryFixture.java@262 PS18, Line 262: Revert this file -- To view, visit http://gerrit.cloudera.org:8080/18178 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I75cf17290be2c64fd4b732a5505bdac31869712a Gerrit-Change-Number: 18178 Gerrit-PatchSet: 18 Gerrit-Owner: Qifan Chen <qc...@cloudera.com> Gerrit-Reviewer: Bikramjeet Vig <bikramjeet....@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Kurt Deschler <kdesc...@cloudera.com> Gerrit-Reviewer: Qifan Chen <qc...@cloudera.com> Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com> Gerrit-Comment-Date: Mon, 07 Mar 2022 14:29:35 +0000 Gerrit-HasComments: Yes
