Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/18385 )
Change subject: IMPALA-11200: Avoid redundant "Codegen enabled" messages in profile ...................................................................... Patch Set 1: > Hi Csaba, thanks for picking this up! > We hit similar issue in the past at IMPALA-9851, where the fix is > to truncate the message to 128kb. > Should we defensively add similar truncation/check in > RuntimeProfileBase::AddInfoStringInternal? Hi Riza! Capping messages to some sane limit makes sense, though I am not sure that it should go to the same commit to make this easy to backport. -- To view, visit http://gerrit.cloudera.org:8080/18385 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iad2e31900ee6d29385cc8adc6bbf067d91f6450f Gerrit-Change-Number: 18385 Gerrit-PatchSet: 1 Gerrit-Owner: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Comment-Date: Wed, 06 Apr 2022 19:20:23 +0000 Gerrit-HasComments: No