Csaba Ringhofer has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/18385 )

Change subject: IMPALA-11200: Avoid redundant "Codegen enabled" messages in 
profile
......................................................................


Patch Set 2:

(1 comment)

Added a regression test, which turned out to be a bit more complex than I 
thought, as I found no easy way to check that a regexp does NOT match any line 
in the profile.

http://gerrit.cloudera.org:8080/#/c/18385/1//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/18385/1//COMMIT_MSG@13
PS1, Line 13:
            :
I have realized that this is not true, we don't report codegen errors here in 
case of async codegen.



--
To view, visit http://gerrit.cloudera.org:8080/18385
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iad2e31900ee6d29385cc8adc6bbf067d91f6450f
Gerrit-Change-Number: 18385
Gerrit-PatchSet: 2
Gerrit-Owner: Csaba Ringhofer <csringho...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com>
Gerrit-Reviewer: Riza Suminto <riza.sumi...@cloudera.com>
Gerrit-Comment-Date: Mon, 11 Apr 2022 13:52:52 +0000
Gerrit-HasComments: Yes

Reply via email to