Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/18399 )
Change subject: IMPALA-10850: Interpret timestamp predicates in local timezone in IcebergScanNode ...................................................................... Patch Set 5: (2 comments) Thanks for the comments. http://gerrit.cloudera.org:8080/#/c/18399/4/fe/src/main/java/org/apache/impala/planner/IcebergScanNode.java File fe/src/main/java/org/apache/impala/planner/IcebergScanNode.java: http://gerrit.cloudera.org:8080/#/c/18399/4/fe/src/main/java/org/apache/impala/planner/IcebergScanNode.java@61 PS4, Line 61: : import com.google.common.base.Preconditions; : > nit: imports got mixed here Thanks, done. http://gerrit.cloudera.org:8080/#/c/18399/4/testdata/datasets/functional/functional_schema_template.sql File testdata/datasets/functional/functional_schema_template.sql: http://gerrit.cloudera.org:8080/#/c/18399/4/testdata/datasets/functional/functional_schema_template.sql@3310 PS4, Line 3310: ==== : ---- DATASET : functional : ---- BASE_TABLE_NAME : iceberg_timestamptz_part : ---- CREATE : CREATE EXTERNAL TABLE IF NOT EXISTS {db_name}{db_suffix}.{table_name} : STORED AS ICEBERG : TBLPROPERTIES('write.format.default'='parquet', 'iceberg.catalog'='hadoop.catalog', : 'iceberg.catalog_location'='/test-warehouse/iceberg_test/hadoop_catalog', : 'iceberg.table_identifier'='ice.iceberg_timestamptz_part'); : ---- DEPENDENT_LOAD : `hadoop fs -mkdir -p /test-warehouse/iceberg_test/hadoop_catalog/ice && \ : hadoop fs -put -f ${IMPALA_HOME}/testdata/data/iceberg_test/hadoop_catalog/ice/iceberg_timestamptz_part /test-warehouse/iceberg_test/hadoop_catalog/ > This table is created twice. Ah, thanks for catching this! Done. -- To view, visit http://gerrit.cloudera.org:8080/18399 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I181be5d2fa004f69b457f69ff82dc2f9877f46fa Gerrit-Change-Number: 18399 Gerrit-PatchSet: 5 Gerrit-Owner: Zoltan Borok-Nagy <borokna...@cloudera.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Tamas Mate <tma...@apache.org> Gerrit-Reviewer: Zoltan Borok-Nagy <borokna...@cloudera.com> Gerrit-Comment-Date: Thu, 14 Apr 2022 15:43:30 +0000 Gerrit-HasComments: Yes
