Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/18399 )
Change subject: IMPALA-10850: Interpret timestamp predicates in local timezone in IcebergScanNode ...................................................................... Patch Set 6: Code-Review+1 (2 comments) http://gerrit.cloudera.org:8080/#/c/18399/6/fe/src/main/java/org/apache/impala/planner/IcebergScanNode.java File fe/src/main/java/org/apache/impala/planner/IcebergScanNode.java: http://gerrit.cloudera.org:8080/#/c/18399/6/fe/src/main/java/org/apache/impala/planner/IcebergScanNode.java@31 PS6, Line 31: import org.apache.iceberg.expressions.UnboundPredicate; : import org.apache.hadoop.fs.Path; nit: order of imports looks wrong http://gerrit.cloudera.org:8080/#/c/18399/6/testdata/workloads/functional-query/queries/QueryTest/iceberg-query.test File testdata/workloads/functional-query/queries/QueryTest/iceberg-query.test: http://gerrit.cloudera.org:8080/#/c/18399/6/testdata/workloads/functional-query/queries/QueryTest/iceberg-query.test@615 PS6, Line 615: aggregation(SUM, NumRowGroups): 5 Hmm, I wonder why we don't drop some of these during stat filtering. Maybe Hive doesn't add stats for timestamp columns? Note that if we want to differentiate between partition and scanner level pruning, a recently introduced counter could be used: NumFileMetadataRead tracks the number of ORC/Parquet files in which we have read the metadata - this should equal to NumRowGroups in case of partition pruning while it should be larger in case of file/row group level stat filtering. An example: https://gerrit.cloudera.org/#/c/18327/17/testdata/workloads/functional-query/queries/QueryTest/runtime_filters.test -- To view, visit http://gerrit.cloudera.org:8080/18399 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I181be5d2fa004f69b457f69ff82dc2f9877f46fa Gerrit-Change-Number: 18399 Gerrit-PatchSet: 6 Gerrit-Owner: Zoltan Borok-Nagy <borokna...@cloudera.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Tamas Mate <tma...@apache.org> Gerrit-Reviewer: Zoltan Borok-Nagy <borokna...@cloudera.com> Gerrit-Comment-Date: Tue, 19 Apr 2022 13:37:00 +0000 Gerrit-HasComments: Yes
