Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/18574 )
Change subject: IMPALA-11279: Optimize plain count(*) queries for Iceberg tables ...................................................................... Patch Set 3: Code-Review+1 (3 comments) Looks great! Thanks for working on this. http://gerrit.cloudera.org:8080/#/c/18574/3//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/18574/3//COMMIT_MSG@17 PS3, Line 17: - SelectStmt does not have WHERE clause > Wouldn't it be also possible to do this if the predicates use only partitio Partitioning might use partition transforms, or maybe the table went through partition evolution, in these cases it's not always possible to return the row count from metadata. http://gerrit.cloudera.org:8080/#/c/18574/3//COMMIT_MSG@22 PS3, Line 22: - SelectList contains only 'count(*)' > While plain "select count(*) from ..." is a very common query, it would be These are good suggestions, but I think it would make sense to keep the scope of this change small, as it is already very useful, and create follow-up Jiras for these tasks. http://gerrit.cloudera.org:8080/#/c/18574/3/be/src/service/client-request-state.cc File be/src/service/client-request-state.cc: http://gerrit.cloudera.org:8080/#/c/18574/3/be/src/service/client-request-state.cc@492 PS3, Line 492: __isset.iceberg_table_name) { : TResultSet response; : RETURN_IF_ERROR(frontend_->GetIcebergTotalRecordsProp maybe we could name these in a more general way, so we could reuse these methods with other table formats. -- To view, visit http://gerrit.cloudera.org:8080/18574 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8e9c48bbba7ab2320fa80915e7001ce54f1ef6d9 Gerrit-Change-Number: 18574 Gerrit-PatchSet: 3 Gerrit-Owner: Anonymous Coward <lipeng...@sensorsdata.cn> Gerrit-Reviewer: Anonymous Coward <lipeng...@sensorsdata.cn> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Gergely Fürnstáhl <gfurnst...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Jian Zhang <zjsar...@gmail.com> Gerrit-Reviewer: Tamas Mate <tma...@apache.org> Gerrit-Reviewer: Xianqing He <hexianqing...@126.com> Gerrit-Reviewer: Zoltan Borok-Nagy <borokna...@cloudera.com> Gerrit-Comment-Date: Tue, 31 May 2022 16:59:04 +0000 Gerrit-HasComments: Yes
