lipeng...@sensorsdata.cn has posted comments on this change. ( http://gerrit.cloudera.org:8080/18574 )
Change subject: IMPALA-11279: Optimize plain count(*) queries for Iceberg tables ...................................................................... Patch Set 5: (3 comments) Thanks again for codereiew. http://gerrit.cloudera.org:8080/#/c/18574/3//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/18574/3//COMMIT_MSG@22 PS3, Line 22: - SelectList contains only 'count(*)' > While plain "select count(*) from ..." is a very common query, it would be Good suggestions, thanks for your codereview, I would like to create a follow-up JIRA for these tasks and contribute to it as we need it. http://gerrit.cloudera.org:8080/#/c/18574/3/be/src/service/client-request-state.cc File be/src/service/client-request-state.cc: http://gerrit.cloudera.org:8080/#/c/18574/3/be/src/service/client-request-state.cc@492 PS3, Line 492: __isset.table_name) { : TResultSet response; : RETURN_IF_ERROR(frontend_->GetTotalRecordsNum( > maybe we could name these in a more general way, so we could reuse these me Done http://gerrit.cloudera.org:8080/#/c/18574/3/fe/src/main/java/org/apache/impala/catalog/FeFsTable.java File fe/src/main/java/org/apache/impala/catalog/FeFsTable.java: http://gerrit.cloudera.org:8080/#/c/18574/3/fe/src/main/java/org/apache/impala/catalog/FeFsTable.java@465 PS3, Line 465: TResultSet result = new TResultSet(); : TResultSetMetadata resultSchema = new TResultSetMetadata(); : result.setSchema(resultSchema); : resultSchema.addToColumns(new TColumn("count(*)", Type.BIGINT.toThrift())); : result.setRows(new ArrayList<>()); > Can you separate this to two functions? Done -- To view, visit http://gerrit.cloudera.org:8080/18574 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8e9c48bbba7ab2320fa80915e7001ce54f1ef6d9 Gerrit-Change-Number: 18574 Gerrit-PatchSet: 5 Gerrit-Owner: Anonymous Coward <lipeng...@sensorsdata.cn> Gerrit-Reviewer: Anonymous Coward <lipeng...@sensorsdata.cn> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Gergely Fürnstáhl <gfurnst...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Jian Zhang <zjsar...@gmail.com> Gerrit-Reviewer: Tamas Mate <tma...@apache.org> Gerrit-Reviewer: Xianqing He <hexianqing...@126.com> Gerrit-Reviewer: Zoltan Borok-Nagy <borokna...@cloudera.com> Gerrit-Comment-Date: Wed, 01 Jun 2022 15:12:35 +0000 Gerrit-HasComments: Yes
