Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/18586 )
Change subject: IMPALA-11314: Test PyPI package with system python ...................................................................... Patch Set 8: (1 comment) http://gerrit.cloudera.org:8080/#/c/18586/8/shell/CMakeLists.txt File shell/CMakeLists.txt: http://gerrit.cloudera.org:8080/#/c/18586/8/shell/CMakeLists.txt@35 PS8, Line 35: add_custom_command(OUTPUT "${PYTHON2_ENV}" : COMMAND impala-virtualenv --python python2 "${PYTHON2_ENV}" : ) I think we would want this to depend on impala_python, which is boostrapping impala-python's virtualenv. We don't want both of these running simultaneously. https://github.com/apache/impala/blob/master/CMakeLists.txt#L473 -- To view, visit http://gerrit.cloudera.org:8080/18586 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I384ea6a7dab51945828cca629860400a23fa0c05 Gerrit-Change-Number: 18586 Gerrit-PatchSet: 8 Gerrit-Owner: Michael Smith <michael.sm...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Michael Smith <michael.sm...@cloudera.com> Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com> Gerrit-Comment-Date: Mon, 06 Jun 2022 18:46:26 +0000 Gerrit-HasComments: Yes
