Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/18586 )
Change subject: IMPALA-11314: Test PyPI package with system python ...................................................................... Patch Set 10: (5 comments) http://gerrit.cloudera.org:8080/#/c/18586/5/bin/bootstrap_system.sh File bin/bootstrap_system.sh: http://gerrit.cloudera.org:8080/#/c/18586/5/bin/bootstrap_system.sh@282 PS5, Line 282: # Install Python 2.x explicitly for CentOS 8 : function setup_python2() > I don't think the specific version of virtualenv is likely to cause issues. Done http://gerrit.cloudera.org:8080/#/c/18586/5/bin/bootstrap_system.sh@284 PS5, Line 284: if command -v python && [[ $(python --versio > I was using virtualenv to generate python2 and python3 environments. venv c Done http://gerrit.cloudera.org:8080/#/c/18586/8/bin/impala-virtualenv File bin/impala-virtualenv: http://gerrit.cloudera.org:8080/#/c/18586/8/bin/impala-virtualenv@20 PS8, Line 20: source "$(dirname "$0")/impala-python-common.sh" > I think I ran into a race-condition with multiple build steps trying to run Done http://gerrit.cloudera.org:8080/#/c/18586/8/shell/CMakeLists.txt File shell/CMakeLists.txt: http://gerrit.cloudera.org:8080/#/c/18586/8/shell/CMakeLists.txt@35 PS8, Line 35: : add_custom_command(OUTPUT "${PYTHON2_ENV}" DEPENDS impala_python : > I think we would want this to depend on impala_python, which is boostrappin Done http://gerrit.cloudera.org:8080/#/c/18586/9/shell/CMakeLists.txt File shell/CMakeLists.txt: http://gerrit.cloudera.org:8080/#/c/18586/9/shell/CMakeLists.txt@29 PS9, Line 29: COMMAND env BUILD_VERSION=install-test OFFICIAL=true > Putting this in shell/build ends up cleaning shell/build without NO_CLEAN_D Done -- To view, visit http://gerrit.cloudera.org:8080/18586 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I384ea6a7dab51945828cca629860400a23fa0c05 Gerrit-Change-Number: 18586 Gerrit-PatchSet: 10 Gerrit-Owner: Michael Smith <michael.sm...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Michael Smith <michael.sm...@cloudera.com> Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com> Gerrit-Comment-Date: Mon, 06 Jun 2022 22:38:57 +0000 Gerrit-HasComments: Yes
