Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/18602 )
Change subject: IMPALA-9615: re2's max_mem opt configurable via an Impala startup flag ...................................................................... Patch Set 4: (2 comments) http://gerrit.cloudera.org:8080/#/c/18602/4/be/src/exprs/string-functions-ir.cc File be/src/exprs/string-functions-ir.cc: http://gerrit.cloudera.org:8080/#/c/18602/4/be/src/exprs/string-functions-ir.cc@941 PS4, Line 941: int64_t re2_max_mem_usage = : ParseUtil::ParseMemSpec(FLAGS_re2_mem_limit, &is_percent, 0); You can validate this flag once in impala::InitCommonRuntime (be/src/common/init.cc). It is probably a good idea too to keep the parsed value somewhere as static variable to avoid parsing it multiple time here. http://gerrit.cloudera.org:8080/#/c/18602/4/tests/custom_cluster/test_re2_max_mem.py File tests/custom_cluster/test_re2_max_mem.py: http://gerrit.cloudera.org:8080/#/c/18602/4/tests/custom_cluster/test_re2_max_mem.py@44 PS4, Line 44: / > flake8: E501 line too long (110 > 90 characters) Can short the link like this: https://github.com/google/re2/blob/3e9622e/re2/re2.h#L619-L648 -- To view, visit http://gerrit.cloudera.org:8080/18602 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Idf28d2f7217b1322ab8fdfb2c02fff0608078571 Gerrit-Change-Number: 18602 Gerrit-PatchSet: 4 Gerrit-Owner: Omid Shahidi <oshah...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Kurt Deschler <kdesc...@cloudera.com> Gerrit-Reviewer: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Comment-Date: Sun, 12 Jun 2022 23:37:01 +0000 Gerrit-HasComments: Yes
