Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/18602 )
Change subject: IMPALA-9615: re2's max_mem opt configurable via an Impala startup flag ...................................................................... Patch Set 6: (7 comments) http://gerrit.cloudera.org:8080/#/c/18602/6//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/18602/6//COMMIT_MSG@15 PS6, Line 15: The re2_max_mem_usage flag will : accept an unsigned int64 The re2_mem_limit will accept a memory specification string http://gerrit.cloudera.org:8080/#/c/18602/6//COMMIT_MSG@21 PS6, Line 21: re2_max_mem_usage re2_mem_limit http://gerrit.cloudera.org:8080/#/c/18602/6/be/src/common/init.cc File be/src/common/init.cc: http://gerrit.cloudera.org:8080/#/c/18602/6/be/src/common/init.cc@346 PS6, Line 346: re2_mem_limit_ nit: re2_mem_limit http://gerrit.cloudera.org:8080/#/c/18602/6/be/src/exprs/string-functions-ir.cc File be/src/exprs/string-functions-ir.cc: http://gerrit.cloudera.org:8080/#/c/18602/6/be/src/exprs/string-functions-ir.cc@53 PS6, Line 53: uint64_t StringFunctions::re2_mem_limit = 8 << 20; Can this initialization moved to string-functions.h, along with the declaration? http://gerrit.cloudera.org:8080/#/c/18602/6/be/src/exprs/string-functions.h File be/src/exprs/string-functions.h: http://gerrit.cloudera.org:8080/#/c/18602/6/be/src/exprs/string-functions.h@159 PS6, Line 159: re2_mem_limit_ nit: re2_mem_limit http://gerrit.cloudera.org:8080/#/c/18602/6/be/src/exprs/string-functions.h@207 PS6, Line 207: re2_mem_limit nit: re2_mem_limit_ Impala C++ Code follows a modified version of the Google C++ Style Guide at: https://google.github.io/styleguide/cppguide.html See https://google.github.io/styleguide/cppguide.html#Variable_Names to contrast between Common Variable names vs Class Data Members. http://gerrit.cloudera.org:8080/#/c/18602/6/tests/custom_cluster/test_re2_max_mem.py File tests/custom_cluster/test_re2_max_mem.py: http://gerrit.cloudera.org:8080/#/c/18602/6/tests/custom_cluster/test_re2_max_mem.py@22 PS6, Line 22: DEFAULT_RE2_MAX_MEM = 8 << 20 Unused variable, please remove. -- To view, visit http://gerrit.cloudera.org:8080/18602 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Idf28d2f7217b1322ab8fdfb2c02fff0608078571 Gerrit-Change-Number: 18602 Gerrit-PatchSet: 6 Gerrit-Owner: Omid Shahidi <oshah...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Kurt Deschler <kdesc...@cloudera.com> Gerrit-Reviewer: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Comment-Date: Mon, 13 Jun 2022 23:28:34 +0000 Gerrit-HasComments: Yes
