Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18641 )
Change subject: IMPALA-11320: SHOW PARTITIONS on Iceberg table doesn't list the partitions ...................................................................... Patch Set 5: (6 comments) http://gerrit.cloudera.org:8080/#/c/18641/5/fe/src/main/java/org/apache/impala/catalog/FeIcebergTable.java File fe/src/main/java/org/apache/impala/catalog/FeIcebergTable.java: http://gerrit.cloudera.org:8080/#/c/18641/5/fe/src/main/java/org/apache/impala/catalog/FeIcebergTable.java@314 PS5, Line 314: Map<String, TIcebergPartitionContent> fieldNameToPartitionValue = table.getIcebergPartitionContent().entrySet().stream() line too long (126 > 90) http://gerrit.cloudera.org:8080/#/c/18641/5/fe/src/main/java/org/apache/impala/catalog/FeIcebergTable.java@319 PS5, Line 319: for (Map.Entry<String, TIcebergPartitionContent> partitionInfo : fieldNameToPartitionValue.entrySet()) { line too long (110 > 90) http://gerrit.cloudera.org:8080/#/c/18641/5/fe/src/main/java/org/apache/impala/catalog/FeIcebergTable.java@592 PS5, Line 592: icebergPartitionContent.num_rows = dataFile.recordCount(); line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/18641/5/fe/src/main/java/org/apache/impala/catalog/IcebergTable.java File fe/src/main/java/org/apache/impala/catalog/IcebergTable.java: http://gerrit.cloudera.org:8080/#/c/18641/5/fe/src/main/java/org/apache/impala/catalog/IcebergTable.java@356 PS5, Line 356: partitionContent_ = Utils.loadPartitionContent(this); tab used for whitespace http://gerrit.cloudera.org:8080/#/c/18641/5/tests/custom_cluster/test_iceberg.py File tests/custom_cluster/test_iceberg.py: http://gerrit.cloudera.org:8080/#/c/18641/5/tests/custom_cluster/test_iceberg.py@25 PS5, Line 25: class TestIcebergCustomConfigs(CustomClusterTestSuite, ImpalaTestSuite): flake8: E302 expected 2 blank lines, found 1 http://gerrit.cloudera.org:8080/#/c/18641/5/tests/custom_cluster/test_iceberg.py@39 PS5, Line 39: a flake8: E501 line too long (94 > 90 characters) -- To view, visit http://gerrit.cloudera.org:8080/18641 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3b4399ae924dadb89875735b12a2f92453b6754c Gerrit-Change-Number: 18641 Gerrit-PatchSet: 5 Gerrit-Owner: Xiaoqing Gao <gaoxq...@gmail.com> Gerrit-Reviewer: Anonymous Coward <lipeng...@sensorsdata.cn> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Tamas Mate <tma...@apache.org> Gerrit-Reviewer: Zoltan Borok-Nagy <borokna...@cloudera.com> Gerrit-Comment-Date: Fri, 24 Jun 2022 13:09:01 +0000 Gerrit-HasComments: Yes
