Xiaoqing Gao has posted comments on this change. ( http://gerrit.cloudera.org:8080/18641 )
Change subject: IMPALA-11320: SHOW PARTITIONS on Iceberg table doesn't list the partitions ...................................................................... Patch Set 4: (7 comments) http://gerrit.cloudera.org:8080/#/c/18641/4/fe/src/main/java/org/apache/impala/catalog/FeIcebergTable.java File fe/src/main/java/org/apache/impala/catalog/FeIcebergTable.java: http://gerrit.cloudera.org:8080/#/c/18641/4/fe/src/main/java/org/apache/impala/catalog/FeIcebergTable.java@310 PS4, Line 310: resultSchema.addToColumns(new TColumn("Number Of Files", Type.BIGINT.toThrift())); : resultSchema.addToColumns(new TColumn("Number Of Rows", Type.BIGINT.toThrift())); > Seems like Hive outputs "Number of Rows" first, then "Number of Files": Done http://gerrit.cloudera.org:8080/#/c/18641/4/fe/src/main/java/org/apache/impala/catalog/FeIcebergTable.java@565 PS4, Line 565: loadPartitionContent > Could you please separate this to two functions? Done http://gerrit.cloudera.org:8080/#/c/18641/4/fe/src/main/java/org/apache/impala/catalog/FeIcebergTable.java@574 PS4, Line 574: map > rename it 'fieldNameToPartitionValue' to make a little bit more sense. Thanks for your suggestion http://gerrit.cloudera.org:8080/#/c/18641/4/fe/src/main/java/org/apache/impala/catalog/FeIcebergTable.java@581 PS4, Line 581: partValueString = table.getNullPartitionKeyValue(); > Please add test for NULL partition key value. Done http://gerrit.cloudera.org:8080/#/c/18641/4/fe/src/main/java/org/apache/impala/catalog/local/LocalIcebergTable.java File fe/src/main/java/org/apache/impala/catalog/local/LocalIcebergTable.java: http://gerrit.cloudera.org:8080/#/c/18641/4/fe/src/main/java/org/apache/impala/catalog/local/LocalIcebergTable.java@77 PS4, Line 77: private Map<String, TIcebergPartitionContent> partitionContent_; > Seems like it doesn't get initialized anywhere. Thanks for your suggestion. I added this in e2e http://gerrit.cloudera.org:8080/#/c/18641/4/fe/src/main/java/org/apache/impala/catalog/local/LocalIcebergTable.java@123 PS4, Line 123: defaultPartitionSpecId_ = tableInfo.getIceberg_table().getDefault_partition_spec_id(); > I think we could initialize 'partitionContent_' somewhere here. Done http://gerrit.cloudera.org:8080/#/c/18641/4/testdata/workloads/functional-query/queries/QueryTest/iceberg-create.test File testdata/workloads/functional-query/queries/QueryTest/iceberg-create.test: http://gerrit.cloudera.org:8080/#/c/18641/4/testdata/workloads/functional-query/queries/QueryTest/iceberg-create.test@40 PS4, Line 40: SHOW PARTITIONS iceberg_hadoop_tables; > Maybe we can keep one 'SHOW PARTITIONS', but the others seem quite unnecess Done -- To view, visit http://gerrit.cloudera.org:8080/18641 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3b4399ae924dadb89875735b12a2f92453b6754c Gerrit-Change-Number: 18641 Gerrit-PatchSet: 4 Gerrit-Owner: Xiaoqing Gao <gaoxq...@gmail.com> Gerrit-Reviewer: Anonymous Coward <lipeng...@sensorsdata.cn> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Tamas Mate <tma...@apache.org> Gerrit-Reviewer: Xiaoqing Gao <gaoxq...@gmail.com> Gerrit-Reviewer: Zoltan Borok-Nagy <borokna...@cloudera.com> Gerrit-Comment-Date: Fri, 24 Jun 2022 13:28:52 +0000 Gerrit-HasComments: Yes
