Xiaoqing Gao has posted comments on this change. ( http://gerrit.cloudera.org:8080/18641 )
Change subject: IMPALA-11320: SHOW PARTITIONS on Iceberg table doesn't list the partitions ...................................................................... Patch Set 10: (6 comments) http://gerrit.cloudera.org:8080/#/c/18641/8/common/thrift/CatalogObjects.thrift File common/thrift/CatalogObjects.thrift: http://gerrit.cloudera.org:8080/#/c/18641/8/common/thrift/CatalogObjects.thrift@574 PS8, Line 574: TIcebergPartitionStats { > nit: maybe a better name would be TIcebergPartitionStats or TIcebergPartiti Done http://gerrit.cloudera.org:8080/#/c/18641/8/fe/src/main/java/org/apache/impala/catalog/FeIcebergTable.java File fe/src/main/java/org/apache/impala/catalog/FeIcebergTable.java: http://gerrit.cloudera.org:8080/#/c/18641/8/fe/src/main/java/org/apache/impala/catalog/FeIcebergTable.java@303 PS8, Line 303: getPartitionStats > nit: now a better name would be getPartitionStats() or getPartitionInfo() Done http://gerrit.cloudera.org:8080/#/c/18641/8/fe/src/main/java/org/apache/impala/catalog/FeIcebergTable.java@310 PS8, Line 310: Partition", Ty > nit: I think it's rather 'Partition' than 'Partition Name'. Done http://gerrit.cloudera.org:8080/#/c/18641/8/fe/src/main/java/org/apache/impala/catalog/iceberg/IcebergCtasTarget.java File fe/src/main/java/org/apache/impala/catalog/iceberg/IcebergCtasTarget.java: http://gerrit.cloudera.org:8080/#/c/18641/8/fe/src/main/java/org/apache/impala/catalog/iceberg/IcebergCtasTarget.java@264 PS8, Line 264: > nit: I think we could just return null here, no need for the member. Thank you very much for your idea. http://gerrit.cloudera.org:8080/#/c/18641/8/testdata/workloads/functional-query/queries/QueryTest/iceberg-partitioned-insert.test File testdata/workloads/functional-query/queries/QueryTest/iceberg-partitioned-insert.test: http://gerrit.cloudera.org:8080/#/c/18641/8/testdata/workloads/functional-query/queries/QueryTest/iceberg-partitioned-insert.test@45 PS8, Line 45: ull}',1,1 > nit: Iceberg just uses null here (without quotes): https://github.com/apach Done http://gerrit.cloudera.org:8080/#/c/18641/8/tests/custom_cluster/test_iceberg.py File tests/custom_cluster/test_iceberg.py: http://gerrit.cloudera.org:8080/#/c/18641/8/tests/custom_cluster/test_iceberg.py@26 PS8, Line 26: > I'm not strongly against this, but there is no need to put these tests into Done -- To view, visit http://gerrit.cloudera.org:8080/18641 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3b4399ae924dadb89875735b12a2f92453b6754c Gerrit-Change-Number: 18641 Gerrit-PatchSet: 10 Gerrit-Owner: Xiaoqing Gao <gaoxq...@gmail.com> Gerrit-Reviewer: Anonymous Coward <lipeng...@sensorsdata.cn> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Tamas Mate <tma...@apache.org> Gerrit-Reviewer: Xiaoqing Gao <gaoxq...@gmail.com> Gerrit-Reviewer: Zoltan Borok-Nagy <borokna...@cloudera.com> Gerrit-Comment-Date: Sat, 02 Jul 2022 06:49:11 +0000 Gerrit-HasComments: Yes
