Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/18641 )
Change subject: IMPALA-11320: SHOW PARTITIONS on Iceberg table doesn't list the partitions ...................................................................... Patch Set 10: Code-Review+1 (4 comments) Thank you for applying the changes. Left some nit comments where the patch still uses the old names. Otherwise LGTM! http://gerrit.cloudera.org:8080/#/c/18641/10/common/thrift/CatalogObjects.thrift File common/thrift/CatalogObjects.thrift: http://gerrit.cloudera.org:8080/#/c/18641/10/common/thrift/CatalogObjects.thrift@597 PS10, Line 597: content nit: I think we should rename this as well http://gerrit.cloudera.org:8080/#/c/18641/10/fe/src/main/java/org/apache/impala/catalog/FeIcebergTable.java File fe/src/main/java/org/apache/impala/catalog/FeIcebergTable.java: http://gerrit.cloudera.org:8080/#/c/18641/10/fe/src/main/java/org/apache/impala/catalog/FeIcebergTable.java@85 PS10, Line 85: Content nit: Stats http://gerrit.cloudera.org:8080/#/c/18641/10/fe/src/main/java/org/apache/impala/catalog/FeIcebergTable.java@585 PS10, Line 585: Conten nit: Stats http://gerrit.cloudera.org:8080/#/c/18641/10/fe/src/main/java/org/apache/impala/catalog/IcebergTable.java File fe/src/main/java/org/apache/impala/catalog/IcebergTable.java: http://gerrit.cloudera.org:8080/#/c/18641/10/fe/src/main/java/org/apache/impala/catalog/IcebergTable.java@168 PS10, Line 168: Content nit: Stats -- To view, visit http://gerrit.cloudera.org:8080/18641 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3b4399ae924dadb89875735b12a2f92453b6754c Gerrit-Change-Number: 18641 Gerrit-PatchSet: 10 Gerrit-Owner: Xiaoqing Gao <gaoxq...@gmail.com> Gerrit-Reviewer: Anonymous Coward <lipeng...@sensorsdata.cn> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Tamas Mate <tma...@apache.org> Gerrit-Reviewer: Xiaoqing Gao <gaoxq...@gmail.com> Gerrit-Reviewer: Zoltan Borok-Nagy <borokna...@cloudera.com> Gerrit-Comment-Date: Mon, 04 Jul 2022 09:51:08 +0000 Gerrit-HasComments: Yes
