Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/18676 )
Change subject: IMPALA-11430: Support custom hash schema for Kudu range tables ...................................................................... Patch Set 12: (7 comments) http://gerrit.cloudera.org:8080/#/c/18676/11/fe/src/main/java/org/apache/impala/analysis/AlterTableAddDropRangePartitionStmt.java File fe/src/main/java/org/apache/impala/analysis/AlterTableAddDropRangePartitionStmt.java: http://gerrit.cloudera.org:8080/#/c/18676/11/fe/src/main/java/org/apache/impala/analysis/AlterTableAddDropRangePartitionStmt.java@114 PS11, Line 114: ColumnDef colDef = new ColumnDef(col.getName(), new TypeDef(col.getType())); Do we need to analyze 'colDef' here (same as line 107 does)? If not, please add a comment. http://gerrit.cloudera.org:8080/#/c/18676/11/fe/src/main/java/org/apache/impala/analysis/KuduPartitionParam.java File fe/src/main/java/org/apache/impala/analysis/KuduPartitionParam.java: http://gerrit.cloudera.org:8080/#/c/18676/11/fe/src/main/java/org/apache/impala/analysis/KuduPartitionParam.java@215 PS11, Line 215: if nit: need a space after "if" http://gerrit.cloudera.org:8080/#/c/18676/11/fe/src/main/java/org/apache/impala/analysis/RangePartition.java File fe/src/main/java/org/apache/impala/analysis/RangePartition.java: http://gerrit.cloudera.org:8080/#/c/18676/11/fe/src/main/java/org/apache/impala/analysis/RangePartition.java@274 PS11, Line 274: if nit: need a space after "if" http://gerrit.cloudera.org:8080/#/c/18676/11/fe/src/main/java/org/apache/impala/catalog/FeKuduTable.java File fe/src/main/java/org/apache/impala/catalog/FeKuduTable.java: http://gerrit.cloudera.org:8080/#/c/18676/11/fe/src/main/java/org/apache/impala/catalog/FeKuduTable.java@243 PS11, Line 243: public static TResultSet getHashSchema(FeKuduTable table) Can we merge this function to the above one by adding a boolean parameter for showHashSchema? It seems the codes are duplicated except the header string and the invocation of either kuduTable.getFormattedRangePartitions() or kuduTable.getFormattedRangePartitionsWithHashSchema(). http://gerrit.cloudera.org:8080/#/c/18676/11/fe/src/main/java/org/apache/impala/service/KuduCatalogOpExecutor.java File fe/src/main/java/org/apache/impala/service/KuduCatalogOpExecutor.java: http://gerrit.cloudera.org:8080/#/c/18676/11/fe/src/main/java/org/apache/impala/service/KuduCatalogOpExecutor.java@417 PS11, Line 417: int seed = 0; Could you add a comment for always using seed=0? http://gerrit.cloudera.org:8080/#/c/18676/11/fe/src/main/java/org/apache/impala/service/KuduCatalogOpExecutor.java@438 PS11, Line 438: nit: need 2 more spaces in indent http://gerrit.cloudera.org:8080/#/c/18676/11/testdata/workloads/functional-query/queries/QueryTest/kudu_partition_ddl.test File testdata/workloads/functional-query/queries/QueryTest/kudu_partition_ddl.test: http://gerrit.cloudera.org:8080/#/c/18676/11/testdata/workloads/functional-query/queries/QueryTest/kudu_partition_ddl.test@94 PS11, Line 94: partition value = (30, 'matthew')) stored as kudu Can we add custom hash partition tests for such multiple column range partitioning schema? -- To view, visit http://gerrit.cloudera.org:8080/18676 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I981056e0827f4957580706d6e73742e4e6743c1c Gerrit-Change-Number: 18676 Gerrit-PatchSet: 12 Gerrit-Owner: Kurt Deschler <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Kurt Deschler <[email protected]> Gerrit-Reviewer: Mahesh Reddy <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Comment-Date: Fri, 15 Jul 2022 02:58:08 +0000 Gerrit-HasComments: Yes
