Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/18676 )
Change subject: IMPALA-11430: Support custom hash schema for Kudu range tables ...................................................................... Patch Set 13: (1 comment) http://gerrit.cloudera.org:8080/#/c/18676/11/fe/src/main/java/org/apache/impala/catalog/FeKuduTable.java File fe/src/main/java/org/apache/impala/catalog/FeKuduTable.java: http://gerrit.cloudera.org:8080/#/c/18676/11/fe/src/main/java/org/apache/impala/catalog/FeKuduTable.java@243 PS11, Line 243: public static TResultSet getHashSchema(FeKuduTable table) > I would rather not merge them as they are likely to diverge further in the hmm, is there a JIRA for the future change? I think we can make separated method when we really need it. Currently we just get range partitions with/without custom hash schema. It doesn't worth duplicating other codes.. -- To view, visit http://gerrit.cloudera.org:8080/18676 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I981056e0827f4957580706d6e73742e4e6743c1c Gerrit-Change-Number: 18676 Gerrit-PatchSet: 13 Gerrit-Owner: Kurt Deschler <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Kurt Deschler <[email protected]> Gerrit-Reviewer: Mahesh Reddy <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Comment-Date: Fri, 15 Jul 2022 13:08:05 +0000 Gerrit-HasComments: Yes
