Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/18838 )
Change subject: IMPALA-11483: [DOCS] Document EXPIRE SNAPSHOTS functionality ...................................................................... Patch Set 1: (3 comments) Quick comments... http://gerrit.cloudera.org:8080/#/c/18838/1/docs/topics/impala_iceberg.xml File docs/topics/impala_iceberg.xml: http://gerrit.cloudera.org:8080/#/c/18838/1/docs/topics/impala_iceberg.xml@513 PS1, Line 513: Iceberg snapshots accumulate until they are expired. Snapshots can be expired wih Expiration sounds like something that might happen automatically. I think we should make it clear that expiration is not automatic. We could say "until they are deleted by a user action. Snapshots can be deleted with", and then "which will delete snapshots". This assumes that I am understanding how it works. Spelling: "with" http://gerrit.cloudera.org:8080/#/c/18838/1/docs/topics/impala_iceberg.xml@525 PS1, Line 525: <li>does not remove orphanned data files.</li> Spelling: "orphaned" http://gerrit.cloudera.org:8080/#/c/18838/1/docs/topics/impala_iceberg.xml@526 PS1, Line 526: <li>respects the minumum snapshots to keep: Spelling: "minimum" -- To view, visit http://gerrit.cloudera.org:8080/18838 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iddd927dd1b6ee3b99dd29982018a610389e64836 Gerrit-Change-Number: 18838 Gerrit-PatchSet: 1 Gerrit-Owner: Tamas Mate <tma...@apache.org> Gerrit-Reviewer: Andrew Sherman <asher...@cloudera.com> Gerrit-Reviewer: Gabor Kaszab <gaborkas...@cloudera.com> Gerrit-Reviewer: Gergely Fürnstáhl <gfurnst...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Zoltan Borok-Nagy <borokna...@cloudera.com> Gerrit-Comment-Date: Thu, 11 Aug 2022 15:42:17 +0000 Gerrit-HasComments: Yes
