Gergely Fürnstáhl has posted comments on this change. ( http://gerrit.cloudera.org:8080/18838 )
Change subject: IMPALA-11483: [DOCS] Document EXPIRE SNAPSHOTS functionality ...................................................................... Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/18838/1/docs/topics/impala_iceberg.xml File docs/topics/impala_iceberg.xml: http://gerrit.cloudera.org:8080/#/c/18838/1/docs/topics/impala_iceberg.xml@513 PS1, Line 513: Iceberg snapshots accumulate until they are expired This does not feel quite right. It suggests that the accumulation stops on expiration, which is not true. The snapshots stop to exist on expiration, the accumulation continues. And I would use the vocabulary of the statement and then explain what it does. Maybe the following is clearer: "Iceberg snapshots accumulate indefinitely. Snapshots can be expired with ... which will delete snapshots older than ..." http://gerrit.cloudera.org:8080/#/c/18838/1/docs/topics/impala_iceberg.xml@526 PS1, Line 526: minumum snapshots I think minimum should refer to the quantity in this case "minimum number of snapshots" -- To view, visit http://gerrit.cloudera.org:8080/18838 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iddd927dd1b6ee3b99dd29982018a610389e64836 Gerrit-Change-Number: 18838 Gerrit-PatchSet: 1 Gerrit-Owner: Tamas Mate <tma...@apache.org> Gerrit-Reviewer: Andrew Sherman <asher...@cloudera.com> Gerrit-Reviewer: Gabor Kaszab <gaborkas...@cloudera.com> Gerrit-Reviewer: Gergely Fürnstáhl <gfurnst...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Zoltan Borok-Nagy <borokna...@cloudera.com> Gerrit-Comment-Date: Mon, 15 Aug 2022 10:06:48 +0000 Gerrit-HasComments: Yes
