Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/18134 )
Change subject: IMPALA-9999: Switch to GCC 10.4 ...................................................................... Patch Set 10: (1 comment) http://gerrit.cloudera.org:8080/#/c/18134/10/be/src/runtime/string-value.inline.h File be/src/runtime/string-value.inline.h: http://gerrit.cloudera.org:8080/#/c/18134/10/be/src/runtime/string-value.inline.h@41 PS10, Line 41: // GCC gives a warning about overflowing the size argument of memcmp, because > This isn't something we want to update to use an unsigned int? The int type is coming from StringValue/StringVal's len field. These are used all over the place, and StringVal is part of our UDF interface. My general read is that switching to unsigned would be a lot of work that doesn't get us a lot. I'm open to ideas. Another alternative is to have: const int result = (len <= 0) ? 0 : memcmp(s1, s2, len) -- To view, visit http://gerrit.cloudera.org:8080/18134 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibe6857b822925226d39fd4d6413457ef6bbaabec Gerrit-Change-Number: 18134 Gerrit-PatchSet: 10 Gerrit-Owner: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Abhishek Rawat <ara...@cloudera.com> Gerrit-Reviewer: Andrew Sherman <asher...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Michael Smith <michael.sm...@cloudera.com> Gerrit-Comment-Date: Thu, 18 Aug 2022 03:49:27 +0000 Gerrit-HasComments: Yes
