Hello Andrew Sherman, Abhishek Rawat, Michael Smith, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/18134 to look at the new patch set (#11). Change subject: IMPALA-9999: Switch to GCC 10.4 ...................................................................... IMPALA-9999: Switch to GCC 10.4 This upgrades GCC and libstdc++ to version 10.4. This required patching or upgrading several dependencies so they could compile with GCC 10. The toolchain companion change has details on what items needed to be upgraded and why. The toolchain companion change switches GCC to build with toolchain binutils rather than host binutils. This means that the python virtualenv initialization needs to include binutils on the path. This disables two warnings introduced in the new GCC versions (Wclass-memaccess and Winit-list-lifetime). These two warnings occur in our code and also in dependencies like LLVM and rapidjson. These are not critical warnings, so they can be addressed independently and reenabled later. Binary sizes increase, particulary when including debug symbols: | GCC 7.5 | GCC 10.4 impalad RELEASE stripped | 83204768 | 88702824 impalad RELEASE | 707278904 | 971711456 impalad DEBUG stripped | 106677672 | 97391944 impalad DEBUG | 725864760 | 867647512 Testing: - Multiple test jobs (core, release exhaustive, ASAN) - Performance testing for TPC-H and TPC-DS shows a modest improvement (2-4%). - Code compiles without warnings on debug and release Change-Id: Ibe6857b822925226d39fd4d6413457ef6bbaabec --- M be/CMakeLists.txt M be/src/codegen/llvm-codegen-test.cc M be/src/runtime/string-value.inline.h M be/src/udf/udf.cc M be/src/util/parquet-reader.cc M bin/impala-config.sh M fe/pom.xml M infra/python/bootstrap_virtualenv.py 8 files changed, 54 insertions(+), 18 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/34/18134/11 -- To view, visit http://gerrit.cloudera.org:8080/18134 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ibe6857b822925226d39fd4d6413457ef6bbaabec Gerrit-Change-Number: 18134 Gerrit-PatchSet: 11 Gerrit-Owner: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Abhishek Rawat <ara...@cloudera.com> Gerrit-Reviewer: Andrew Sherman <asher...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Michael Smith <michael.sm...@cloudera.com>