Fang-Yu Rao has posted comments on this change. ( http://gerrit.cloudera.org:8080/18938 )
Change subject: IMPALA-11548: Share same TTransport object for RPC input and output ...................................................................... Patch Set 1: (3 comments) Thanks for the thorough investigation Riza and Joe! I only have the following very minor comments. http://gerrit.cloudera.org:8080/#/c/18938/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/18938/1//COMMIT_MSG@10 PS1, Line 10: falling with the max message size error nit: Maybe it would be more accurate to change this to "closed by the Thrift server due to MaxMessageSize reached". http://gerrit.cloudera.org:8080/#/c/18938/1//COMMIT_MSG@14 PS1, Line 14: point nit: Change it to "points" or "pointed". http://gerrit.cloudera.org:8080/#/c/18938/1/be/src/rpc/TAcceptQueueServer.cpp File be/src/rpc/TAcceptQueueServer.cpp: http://gerrit.cloudera.org:8080/#/c/18938/1/be/src/rpc/TAcceptQueueServer.cpp@242 PS1, Line 242: help with nit: helps with simplifying -- To view, visit http://gerrit.cloudera.org:8080/18938 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I199d6b0c6c62e940e131eb39d38a8a51b36e11c4 Gerrit-Change-Number: 18938 Gerrit-PatchSet: 1 Gerrit-Owner: Riza Suminto <[email protected]> Gerrit-Reviewer: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Mon, 05 Sep 2022 17:57:25 +0000 Gerrit-HasComments: Yes
