Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/18938 )
Change subject: IMPALA-11548: Share same TTransport object for RPC input and output ...................................................................... Patch Set 2: Code-Review+1 (1 comment) It is good to see the old hack removed! http://gerrit.cloudera.org:8080/#/c/18938/2/be/src/rpc/TAcceptQueueServer.cpp File be/src/rpc/TAcceptQueueServer.cpp: http://gerrit.cloudera.org:8080/#/c/18938/2/be/src/rpc/TAcceptQueueServer.cpp@246 PS2, Line 246: inputTransport = inputTransportFactory_->getTransport(client); : outputTransport = inputTransport; As the two are now the same, can you merge a variables? e.g. as transport or inputOutputTransport The function CleanupAndClose could be also simplified to expect only a single transport. Currently we call close() two time on the same transport if there is some error, which may not be ok for some transports. -- To view, visit http://gerrit.cloudera.org:8080/18938 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I199d6b0c6c62e940e131eb39d38a8a51b36e11c4 Gerrit-Change-Number: 18938 Gerrit-PatchSet: 2 Gerrit-Owner: Riza Suminto <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Tue, 06 Sep 2022 11:49:43 +0000 Gerrit-HasComments: Yes
