Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/18990 )
Change subject: IMPALA-10660: Impala shell prints DOUBLEs with less precision in HS2 than beeswax ...................................................................... Patch Set 2: (3 comments) Are there any security implications of accepting user input as format strings? Can we say it is completely safe? http://gerrit.cloudera.org:8080/#/c/18990/2/shell/impala_client.py File shell/impala_client.py: http://gerrit.cloudera.org:8080/#/c/18990/2/shell/impala_client.py@63 PS2, Line 63: HS2_VALUE_GETTERS = { Update the comment section above, as this has changed. http://gerrit.cloudera.org:8080/#/c/18990/2/shell/value_converter.py File shell/value_converter.py: http://gerrit.cloudera.org:8080/#/c/18990/2/shell/value_converter.py@32 PS2, Line 32: HS2_VALUE_CONVERTERS Is it intentional that it is a class (static) variable? I think it would be clearer as a member variable. http://gerrit.cloudera.org:8080/#/c/18990/2/shell/value_converter.py@32 PS2, Line 32: HS2_VALUE_CONVERTERS = { Is it intentional that FLOAT and DOUBLE are not in this map? Don't we need the 'str' as a default value, if we need it for other types? What about STRING, CHAR, complex types etc.? -- To view, visit http://gerrit.cloudera.org:8080/18990 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I424339266be66437941be8bafaa83fa0f2dfbd4e Gerrit-Change-Number: 18990 Gerrit-PatchSet: 2 Gerrit-Owner: Peter Rozsa <pro...@cloudera.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Daniel Becker <daniel.bec...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Comment-Date: Fri, 16 Sep 2022 13:12:09 +0000 Gerrit-HasComments: Yes
