Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/18990 )
Change subject: IMPALA-10660: Impala shell prints DOUBLEs with less precision in HS2 than beeswax ...................................................................... Patch Set 2: (4 comments) http://gerrit.cloudera.org:8080/#/c/18990/2/shell/option_parser.py File shell/option_parser.py: http://gerrit.cloudera.org:8080/#/c/18990/2/shell/option_parser.py@324 PS2, Line 324: fp_format_specification It would be nice to contain the info in the name that this only applies to hs2, e.g hs2_fp_format http://gerrit.cloudera.org:8080/#/c/18990/2/shell/option_parser.py@326 PS2, Line 326: help Can you add info also about the default Python behavior and the value needed to match with Beeswax? http://gerrit.cloudera.org:8080/#/c/18990/1/tests/shell/test_shell_commandline.py File tests/shell/test_shell_commandline.py: http://gerrit.cloudera.org:8080/#/c/18990/1/tests/shell/test_shell_commandline.py@1312 PS1, Line 1312: args = ['--fp_format_specification', '.16f', '-q', Can you http://gerrit.cloudera.org:8080/#/c/18990/2/tests/shell/test_shell_commandline.py File tests/shell/test_shell_commandline.py: http://gerrit.cloudera.org:8080/#/c/18990/2/tests/shell/test_shell_commandline.py@1312 PS2, Line 1312: 16f The value was chosen to match with beeswax, right? I think that we could skip this test for beeswax (or at least skip most of the test). Also, can you add a few more tests? Some ideas: - test both float and double - also test the default behavior - also test > a 1 value - test a NaN value - test a negative value - test a different format spec - I think that we should also get the result in scientific notation in some cases, it would be nice to have a test for that -- To view, visit http://gerrit.cloudera.org:8080/18990 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I424339266be66437941be8bafaa83fa0f2dfbd4e Gerrit-Change-Number: 18990 Gerrit-PatchSet: 2 Gerrit-Owner: Peter Rozsa <pro...@cloudera.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Daniel Becker <daniel.bec...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Comment-Date: Fri, 16 Sep 2022 15:42:54 +0000 Gerrit-HasComments: Yes
