Peter Rozsa has posted comments on this change. ( http://gerrit.cloudera.org:8080/18990 )
Change subject: IMPALA-10660: Impala shell prints DOUBLEs with less precision in HS2 than beeswax ...................................................................... Patch Set 5: (1 comment) Tests: https://master-03.jenkins.cloudera.com/job/impala-private-basic-parameterized/814/ http://gerrit.cloudera.org:8080/#/c/18990/5/shell/impala_shell.py File shell/impala_shell.py: http://gerrit.cloudera.org:8080/#/c/18990/5/shell/impala_shell.py@1939 PS5, Line 1939: format_str = "{:%s}" % format_specification > The user input was inserted after the ':' in Patch Set 3 as well, wasn't it With a named replacement field, there is a possibility that the user gives 'value' or '{value}' as an input. In this case, the formatting would put the floating point value into the format string like this '0.123:0.123', which is not correct. Without a named replacement field there's no such case -- To view, visit http://gerrit.cloudera.org:8080/18990 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I424339266be66437941be8bafaa83fa0f2dfbd4e Gerrit-Change-Number: 18990 Gerrit-PatchSet: 5 Gerrit-Owner: Peter Rozsa <pro...@cloudera.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Daniel Becker <daniel.bec...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Peter Rozsa <pro...@cloudera.com> Gerrit-Comment-Date: Thu, 22 Sep 2022 07:00:48 +0000 Gerrit-HasComments: Yes
