Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/19001 )
Change subject: IMPALA-11562: Revert support for o3fs as default filesystem ...................................................................... Patch Set 8: Code-Review+1 (2 comments) Thanks for fixing this and also cleaning up the code a bit. I think all relevant Iceberg paths are updated. (Iceberg V2 position delete files also contain file paths, but rewriting them is harder as they are in Parquet/ORC, also currently we don't execute such tests on non-HDFS filesystems) http://gerrit.cloudera.org:8080/#/c/19001/8/testdata/workloads/functional-query/queries/QueryTest/iceberg-alter.test File testdata/workloads/functional-query/queries/QueryTest/iceberg-alter.test: http://gerrit.cloudera.org:8080/#/c/19001/8/testdata/workloads/functional-query/queries/QueryTest/iceberg-alter.test@77 PS8, Line 77: other where does this 'other' come from? Is this just a dummy bucket/folder? I'm not sure if it was intentional that we didn't put everything under /test-warehouse. Anyway I'm OK with it, but not sure if our cleaning/format scripts remove data from these locations (if the test doesn't clean up for itself). http://gerrit.cloudera.org:8080/#/c/19001/8/tests/custom_cluster/test_startup_filesystem_checks.py File tests/custom_cluster/test_startup_filesystem_checks.py: http://gerrit.cloudera.org:8080/#/c/19001/8/tests/custom_cluster/test_startup_filesystem_checks.py@50 PS8, Line 50: "/" Shouldn't we add get_fs_path() here as well? -- To view, visit http://gerrit.cloudera.org:8080/19001 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I45e90d30b2e68876dec0db3c43ac15ee510b17bd Gerrit-Change-Number: 19001 Gerrit-PatchSet: 8 Gerrit-Owner: Michael Smith <michael.sm...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Michael Smith <michael.sm...@cloudera.com> Gerrit-Reviewer: Zoltan Borok-Nagy <borokna...@cloudera.com> Gerrit-Comment-Date: Tue, 27 Sep 2022 16:53:20 +0000 Gerrit-HasComments: Yes