Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/19001 )
Change subject: IMPALA-11562: Revert support for o3fs as default filesystem ...................................................................... Patch Set 8: (2 comments) http://gerrit.cloudera.org:8080/#/c/19001/8/testdata/workloads/functional-query/queries/QueryTest/iceberg-alter.test File testdata/workloads/functional-query/queries/QueryTest/iceberg-alter.test: http://gerrit.cloudera.org:8080/#/c/19001/8/testdata/workloads/functional-query/queries/QueryTest/iceberg-alter.test@77 PS8, Line 77: other > It was meant to be a placeholder. I assumed there was a reason it wasn't or As far as I can tell the test cleans up after itself. Format deletes everything in the distributed FS, so that works for a full clean. http://gerrit.cloudera.org:8080/#/c/19001/8/tests/custom_cluster/test_startup_filesystem_checks.py File tests/custom_cluster/test_startup_filesystem_checks.py: http://gerrit.cloudera.org:8080/#/c/19001/8/tests/custom_cluster/test_startup_filesystem_checks.py@50 PS8, Line 50: "/" > It wasn't necessary, but wouldn't hurt. It's just checking that they're val Actually it's just checking that they're valid directories, checking '/' is fine and doesn't hurt anything. -- To view, visit http://gerrit.cloudera.org:8080/19001 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I45e90d30b2e68876dec0db3c43ac15ee510b17bd Gerrit-Change-Number: 19001 Gerrit-PatchSet: 8 Gerrit-Owner: Michael Smith <michael.sm...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Michael Smith <michael.sm...@cloudera.com> Gerrit-Reviewer: Zoltan Borok-Nagy <borokna...@cloudera.com> Gerrit-Comment-Date: Tue, 27 Sep 2022 17:14:36 +0000 Gerrit-HasComments: Yes
