Xiang Yang has posted comments on this change. ( http://gerrit.cloudera.org:8080/18861 )
Change subject: IMPALA-11504: Specializing DecimalUtil::GetScaleMultiplier<int256_t>(). ...................................................................... Patch Set 8: (4 comments) http://gerrit.cloudera.org:8080/#/c/18861/6//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/18861/6//COMMIT_MSG@12 PS6, Line 12: > Indicate also here how much the speedup is resulting from this template spe Done http://gerrit.cloudera.org:8080/#/c/18861/6/be/src/benchmarks/decimal-util-benchmark.cc File be/src/benchmarks/decimal-util-benchmark.cc: http://gerrit.cloudera.org:8080/#/c/18861/6/be/src/benchmarks/decimal-util-benchmark.cc@26 PS6, Line 26: // > I agree with Lipenglin, we should mention that it was done in a Docker cont Done http://gerrit.cloudera.org:8080/#/c/18861/6/be/src/benchmarks/decimal-util-benchmark.cc@53 PS6, Line 53: > I think in this case 'volatile_var' or something similar would be more desc Done http://gerrit.cloudera.org:8080/#/c/18861/4/be/src/util/decimal-util.h File be/src/util/decimal-util.h: http://gerrit.cloudera.org:8080/#/c/18861/4/be/src/util/decimal-util.h@37 PS4, Line 37: // The scale's exclusive upper bound for GetScaleMultiplier<int32_t>() : static constexpr int INT32_SCALE_UPPER_BOUND = ColumnType::MAX_DECIMAL4_PRECISION + 1; : // The scale's exclusive upper bound for GetScaleMultiplier<int64_t>() : static constexpr int INT64_SCALE_UPPER_BOUND = ColumnType::MAX_DECIMAL8_PRECISION + 1; : // The scale's exclusive upper bound for GetScaleMultiplier<int128_t>() : static constexpr int INT128_SCALE_UPPER_BOUND = ColumnType::MAX_PRECISION + 1; : // The scale's exclusive upper bound for GetScaleMultiplier<int256_t>() : static constexpr int INT256_SCALE_UPPER_BOUND = 77; > Ok, we can let them stay. Done -- To view, visit http://gerrit.cloudera.org:8080/18861 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I969e2977d51313e738f72c8246db003ae43a3782 Gerrit-Change-Number: 18861 Gerrit-PatchSet: 8 Gerrit-Owner: Xiang Yang <yx91...@126.com> Gerrit-Reviewer: Anonymous Coward <lipeng...@sensorsdata.cn> Gerrit-Reviewer: Daniel Becker <daniel.bec...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Xiang Yang <yx91...@126.com> Gerrit-Comment-Date: Thu, 06 Oct 2022 02:13:55 +0000 Gerrit-HasComments: Yes
