Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/18861 )
Change subject: IMPALA-11504: Specializing DecimalUtil::GetScaleMultiplier<int256_t>(). ...................................................................... Patch Set 8: (3 comments) Thanks, only a few minor remarks. http://gerrit.cloudera.org:8080/#/c/18861/8/be/src/benchmarks/decimal-util-benchmark.cc File be/src/benchmarks/decimal-util-benchmark.cc: http://gerrit.cloudera.org:8080/#/c/18861/8/be/src/benchmarks/decimal-util-benchmark.cc@25 PS8, Line 25: // Summary result(Ran within a Docker container): Nit: add a space before the parenthesis. http://gerrit.cloudera.org:8080/#/c/18861/8/be/src/benchmarks/decimal-util-benchmark.cc@25 PS8, Line 25: Ran Nit: ran, no need for capital letter. http://gerrit.cloudera.org:8080/#/c/18861/8/be/src/benchmarks/decimal-util-benchmark.cc@54 PS8, Line 54: // A variable to accept the result of the target function, I think this would be better/more understantable: "A volatile variable to hold the return value of the benchmarked functions. Used to prevent the compiler from optimising out the calls." -- To view, visit http://gerrit.cloudera.org:8080/18861 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I969e2977d51313e738f72c8246db003ae43a3782 Gerrit-Change-Number: 18861 Gerrit-PatchSet: 8 Gerrit-Owner: Xiang Yang <yx91...@126.com> Gerrit-Reviewer: Anonymous Coward <lipeng...@sensorsdata.cn> Gerrit-Reviewer: Daniel Becker <daniel.bec...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Xiang Yang <yx91...@126.com> Gerrit-Comment-Date: Thu, 06 Oct 2022 13:23:13 +0000 Gerrit-HasComments: Yes
