Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/19150 )
Change subject: IMPALA-11608: Fix SHOW TABLE STATS iceberg_tbl shows wrong number of files ...................................................................... Patch Set 1: (3 comments) Thanks for working on this! The change looks good overall, left some minor comments. http://gerrit.cloudera.org:8080/#/c/19150/1/fe/src/main/java/org/apache/impala/catalog/FeIcebergTable.java File fe/src/main/java/org/apache/impala/catalog/FeIcebergTable.java: http://gerrit.cloudera.org:8080/#/c/19150/1/fe/src/main/java/org/apache/impala/catalog/FeIcebergTable.java@730 PS1, Line 730: } shouldn't we add an else branch? http://gerrit.cloudera.org:8080/#/c/19150/1/testdata/workloads/functional-query/queries/QueryTest/iceberg-compute-stats.test File testdata/workloads/functional-query/queries/QueryTest/iceberg-compute-stats.test: http://gerrit.cloudera.org:8080/#/c/19150/1/testdata/workloads/functional-query/queries/QueryTest/iceberg-compute-stats.test@24 PS1, Line 24: $NAMENODE/ Probably $WAREHOUSE_LOCATION_PREFIX is better http://gerrit.cloudera.org:8080/#/c/19150/1/testdata/workloads/functional-query/queries/QueryTest/iceberg-v2-read-position-deletes.test File testdata/workloads/functional-query/queries/QueryTest/iceberg-v2-read-position-deletes.test: http://gerrit.cloudera.org:8080/#/c/19150/1/testdata/workloads/functional-query/queries/QueryTest/iceberg-v2-read-position-deletes.test@30 PS1, Line 30: -1 Can we always return a valid #ROWS for Iceberg tables? -- To view, visit http://gerrit.cloudera.org:8080/19150 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I110e5e13cec3aa898f115e1ed795ce98e68ef06c Gerrit-Change-Number: 19150 Gerrit-PatchSet: 1 Gerrit-Owner: Anonymous Coward <lipeng...@sensorsdata.cn> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Xiaoqing Gao <gaoxq...@gmail.com> Gerrit-Reviewer: Zoltan Borok-Nagy <borokna...@cloudera.com> Gerrit-Comment-Date: Tue, 18 Oct 2022 16:26:40 +0000 Gerrit-HasComments: Yes
