Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/19150 )
Change subject: IMPALA-11608: Fix SHOW TABLE STATS iceberg_tbl shows wrong number of files ...................................................................... Patch Set 2: Code-Review+1 (2 comments) Had one minor comment on the ORC tests. Otherwise LGTM. http://gerrit.cloudera.org:8080/#/c/19150/1/testdata/workloads/functional-query/queries/QueryTest/iceberg-compute-stats.test File testdata/workloads/functional-query/queries/QueryTest/iceberg-compute-stats.test: http://gerrit.cloudera.org:8080/#/c/19150/1/testdata/workloads/functional-query/queries/QueryTest/iceberg-compute-stats.test@24 PS1, Line 24: $NAMENODE/ > I noticed that https://github.com/apache/impala/blob/master/testdata/worklo I'm OK with this. Seems like we still use $NAMENODE at most places. http://gerrit.cloudera.org:8080/#/c/19150/2/testdata/workloads/functional-query/queries/QueryTest/iceberg-v2-read-position-deletes-orc.test File testdata/workloads/functional-query/queries/QueryTest/iceberg-v2-read-position-deletes-orc.test: http://gerrit.cloudera.org:8080/#/c/19150/2/testdata/workloads/functional-query/queries/QueryTest/iceberg-v2-read-position-deletes-orc.test@a15 PS2, Line 15: Instead of deleting these tests we should fix them by executing them on ORC: iceberg_v2_positional_delete_all_rows_orc -- To view, visit http://gerrit.cloudera.org:8080/19150 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I110e5e13cec3aa898f115e1ed795ce98e68ef06c Gerrit-Change-Number: 19150 Gerrit-PatchSet: 2 Gerrit-Owner: Anonymous Coward <lipeng...@sensorsdata.cn> Gerrit-Reviewer: Anonymous Coward <lipeng...@sensorsdata.cn> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Xiaoqing Gao <gaoxq...@gmail.com> Gerrit-Reviewer: Zoltan Borok-Nagy <borokna...@cloudera.com> Gerrit-Comment-Date: Fri, 21 Oct 2022 14:29:02 +0000 Gerrit-HasComments: Yes
